[PATCH][RFC] Minuscule patch to remove apparently accidental break from switch

David Daney ddaney@avtrex.com
Tue Jun 5 19:56:00 GMT 2007


Simon Baldwin wrote:
> Andrew Pinski wrote:
> 
>> On 6/5/07, Simon Baldwin <simonb@google.com> wrote:
>>
>>> An apparently misplaced break statement within 
>>> simplify_binary_operation_1()
>>> causes calls to simplify_associative_operation() for xor operations to
>>> potentially be missed.
>>>
>>> This patch removes the break, enabling simplify_associative_operation().
>>>
>>> Regression tested on i386 against the full g++ testsuite.
>>
>>
>> Can you run against the whole testsuite instead of just the g++?  This
>> patch really needs a full bootstrap with all languages enabled as it
>> changes the middle-end.
>>
> 
> Thanks for the note.  That's actually my typo in the patch description; 
> I've actually run both C and C++ testsuites.  That is, all tests enabled 
> by "configure --enable-languages=c,c++".
> 
> Will those cover it, or should I plough through Fortran, ADA, and so on 
> as well?

Just remove the --enable-languages and test all default languages.

David Daney



More information about the Gcc-patches mailing list