[PATCH][RFC] Minuscule patch to remove apparently accidental break from switch

Simon Baldwin simonb@google.com
Tue Jun 5 18:03:00 GMT 2007


An apparently misplaced break statement within simplify_binary_operation_1()
causes calls to simplify_associative_operation() for xor operations to
potentially be missed.

This patch removes the break, enabling simplify_associative_operation().

Regression tested on i386 against the full g++ testsuite.


gcc/ChangeLog
2007-06-05  Simon Baldwin  <simonb@google.com>

	* simplify-rtx.c (simplify_binary_operation_1): Removed erroneous
	break that was preventing simplify_associative_operation() for xor.


diff -Nrcp3 orig/gcc/gcc/simplify-rtx.c gcc/gcc/simplify-rtx.c
*** orig/gcc/gcc/simplify-rtx.c	Mon Jun  4 09:49:07 2007
--- gcc/gcc/simplify-rtx.c	Tue Jun  5 10:52:40 2007
*************** simplify_binary_operation_1 (enum rtx_co
*** 2292,2299 ****
  	  && (reversed = reversed_comparison (op0, mode)))
  	return reversed;
  
-       break;
-       
        tem = simplify_associative_operation (code, mode, op0, op1);
        if (tem)
  	return tem;



More information about the Gcc-patches mailing list