RFA: Handle unsigned characters from string constants in store-ccp

Richard Guenther richard.guenther@gmail.com
Wed Jul 25 12:39:00 GMT 2007


On 7/25/07, Daniel Jacobowitz <drow@false.org> wrote:
> On Tue, Jul 24, 2007 at 10:30:50PM +0200, Richard Guenther wrote:
> > On 7/24/07, Diego Novillo <dnovillo@google.com> wrote:
> > > On 7/24/07 1:00 PM, Daniel Jacobowitz wrote:
> > >
> > > > Is this patch OK?
> > >
> > > Yes.
> >
> > No, you should use build_int_cst_type (TREE_TYPE (t), (unsigned
> > char)...) instead.  (Definitely not use build_int_cst with a NULL type
> > argument)
>
> Sorry, I'd already committed it.  Should the place this code is based
> on change too?  That's fold-convert.c:fold_read_from_constant_string.

Yes, that would be nice.

Thanks,
Richard.



More information about the Gcc-patches mailing list