[PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p

Peter Bergner bergner@vnet.ibm.com
Mon Jul 16 13:26:00 GMT 2007


On Mon, 2007-07-16 at 09:04 +0300, Paolo Bonzini wrote:
> What you suggest can also be obtained with:
> 
> -          if (simplify_plus_minus_op_data_cmp (&ops[j], &ops[i]) < 0)
> +          if (simplify_plus_minus_op_data_cmp (&ops[j], &ops[i]) <= 0)

Right.  However, if the REGNO sorting in swap_commutative_operands_p
stays, then we can just use swap_commutative_operands_p instead of
simplify_plus_minus_op_data_cmp.  If we end up removing that part of
the patch, then the above is the correct fix.  Which should probably
be applied as a cleanup along with Jakub's cleanup fix (the 2nd patch)
that he mentioned here:

    http://gcc.gnu.org/ml/gcc-patches/2007-07/msg00895.html


Peter





More information about the Gcc-patches mailing list