Fwd: [ALL TARGETS] final patch for PR 25241

[Janis Johnson]

On Tue, 2007-07-10 at 17:32 +0100, Manuel López-Ibáñez wrote:
> These patches fix PR  25241 for the C front-end.
> 
> One patch adds the changes needed to fix the testsuite framework and
> the corresponding tests. It wraps the original dg-warning and dg-error
> directives with two custom versions that check that the message
> contains gcc_warning_prefix or gcc_error_prefix, respectively. Then,
> it defines gcc_warning_prefix and gcc_error_prefix for the C front-end
> tests. It also adds two tests to the test-framework testsuite so we
> can be sure that the testsuite is working correctly.
> 
> The other patch removes the explicit "warning" and "error" markers
> used by some tests. This was done automatically by using the attached
> script.
> 
> Regression tested and I also ran the framework tests. Further testing welcome!

My testing on powerpc64-linux for all languages but Ada showed no
surprises except that I needed to approve the change to pch/counter-2.c.

> Unfortunately, I cannot test anything else apart from
> i686-pc-gnu-linux. Thus, some testcases that currently do nasty things
> (like matching multiple error/warnings with one dg-error or dg-warning
> directive) may break. Perhaps, there should be a short lock-down so
> people can test as many targets as possible.

It's OK to fix other problems as we find them, but wait a day to see if
there are any responses to the mail I sent to the gcc mailing list about
testsuite disruptions; as far as I'm concerned, this patch is OK (Manuel
and I have been discussing it for months now).

Janis