[fortran] Disable use of -malign-double

Andrew Pinski pinskia@physics.uc.edu
Wed Jan 31 19:12:00 GMT 2007


> 
> On Tue, Jan 30, 2007 at 11:17:23PM -0800, Andrew Pinski wrote:
> > On Tue, 2007-01-30 at 23:11 -0800, Steve Kargl wrote:
> > > The patch is self explanatory.
> > > 
> > > 2007-01-31  Steven G. Kargl  <kargl@gcc.gnu.org>
> > > 
> > > 	* options.c (gfc_post_options): Abort if -malign-double
> > > 
> > > 
> > > 
> > > Index: options.c
> > > ===================================================================
> > > --- options.c	(revision 121271)
> > > +++ options.c	(working copy)
> > > @@ -294,6 +294,9 @@ gfc_post_options (const char **pfilename
> > >    if (gfc_option.flag_all_intrinsics)
> > >      gfc_option.warn_nonstd_intrinsics = 0;
> > >  
> > > +  if (TARGET_ALIGN_DOUBLE)
> > > +    fatal_error ("-malign-double is incompatible with libgfortran");
> > 
> > This will not work.  As TARGET_ALIGN_DOUBLE is only defined for the x86
> > backend.  Also it could default for some x86 targets.
> > 
> 
> How about this patch?

This is the wrong approach as some target might define -malign-double
to mean something different from x86's definition.  Also I don't think
we should be erroring out if someone compiles the whole libc, libgfortran,
etc. with -malign-double which will work.

-- Pinski



More information about the Gcc-patches mailing list