ping [PATCH] [4.3 projects] vectorization of induction

Zdenek Dvorak rakdver@atrey.karlin.mff.cuni.cz
Mon Jan 15 10:41:00 GMT 2007


Hello,

> http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00005.html

> *************** vect_is_simple_reduction (struct loop *l
> *** 2048,2054 ****
>      */
>     def1 = SSA_NAME_DEF_STMT (op1);
>     def2 = SSA_NAME_DEF_STMT (op2);
> !   if (!def1 || !def2)
>       {
>         if (vect_print_dump_info (REPORT_DETAILS))
>           {
> --- 2041,2047 ----
>      */
>     def1 = SSA_NAME_DEF_STMT (op1);
>     def2 = SSA_NAME_DEF_STMT (op2);
> !   if (!def1 || !def2 || IS_EMPTY_STMT (def1) || IS_EMPTY_STMT (def2))
>       {
>         if (vect_print_dump_info (REPORT_DETAILS))
>           {

Can it really happen that def1 or def2 is NULL?

>	(vectorizable_type_demotion): Use def-type of stmt argument rather
>       than dummy def-type.

What does this change?

> tested on the vectorizer testcases on powerpc-linux.

Full regtesting is required, IMHO.

Otherwise, the patch looks OK to me (although obviously, it introduces a new
functionality, so I cannot approve it).

It might help to submit the formatting-only changes separately the next time,
to make the patch easier to read (I think you can commit such changes without
approval).

Zdenek



More information about the Gcc-patches mailing list