Patch: update documentation for gcj-eclipse merge

Gerald Pfeifer gerald@pfeifer.com
Mon Jan 15 01:26:00 GMT 2007


On Mon, 8 Jan 2007, Tom Tromey wrote:
>> The doc portions of this patch are fine modulo the comments above, as
>> far as I can tell.
> Here's an updated version of the patch.

Duh, I thought you'd go ahead and commit the patch with some changes,
at least that's what I had ment to imply. =:-)  Sorry for the delay.

> from  Tom Tromey  <tromey@redhat.com>
> 
> 	* doc/sourcebuild.texi (libgcj Tests): Don't mention jacks.
> 	* doc/install.texi (Testing): Don't mention jacks.
> 	(Configuration): Document --enable-java-maintainer-mode.  Move
> 	--with-java-home to libgcj-specific section.  Document
> 	--with-ecj-jar.
> 	(Prerequisites): Mention --enable-java-maintainer-mode, ecj1.

The doc changes are fine.  (Did you intentionally sort the ChangeLog
entries in reverse order?)

I cannot approve contrib/download_ecj, but let's just go for it, I'd
say.  No need to get overly anal here.

> +If you wish to modify @file{.java} files in libjava, you will need to
> +configure with @option{--enable-java-maintainer-mode}, and you will need
> +to have executables named @command{ecj1} and @command{gjavah} on your path.

"in your path"?  Not sure about this one.

Gerald



More information about the Gcc-patches mailing list