PATCH RFC: Use parentheses in dumps for same-priority operands

Richard Guenther richard.guenther@gmail.com
Wed Jan 10 15:46:00 GMT 2007


On 10 Jan 2007 06:58:03 -0800, Ian Lance Taylor <iant@google.com> wrote:
> "Richard Guenther" <richard.guenther@gmail.com> writes:
>
> > On 09 Jan 2007 20:35:33 -0800, Ian Lance Taylor <iant@google.com> wrote:
>
> > > With this trivial patch, the dump file looks like this:
> > >
> > > foo (a, b, c)
> > > {
> > > <bb 2>:
> > >   return a - (b - c);
> > >
> > > }
> > >
> > > This correctly represents the order of operations.
> >
> > I think this is a good enhancement.  Does it avoid printing the
> > parens if the evaluation order is left-to-right?
>
> No, it doesn't.  I just kept it simple.  And in any case I actually
> think it's clearer to be explicit in this context.  Do you think
> avoiding the parentheses in that case would be important?

It really depends on the expression size TER constructs for example.
But I don't think it's too important - we can fix this afterwards if it is
too anoying.

Richard.



More information about the Gcc-patches mailing list