PR target/30383 (ICE in i386 stringops rewrite)

Eric Christopher echristo@apple.com
Wed Jan 10 06:42:00 GMT 2007


On Jan 9, 2007, at 4:21 AM, Jan Hubicka wrote:

>>
>> On Jan 8, 2007, at 6:41 PM, Jan Hubicka wrote:
>>
>>>>>
>>>>> ! 	  if (code == LABEL_DECL)
>>>>> ! 	    DECL_ALIGN (t) = BITS_PER_UNIT;
>>>>> ! 	  else if (code != FUNCTION_DECL)
>>>>>
>>>>
>>>> I think you want bytes not bits here.
>>>
>>> DECL_ALIGN is bit based:
>>> /* Holds the alignment required for the datum, in bits.  */
>>
>> Hunh. Brain fart. The real question probably should have been "Are  
>> you
>> sure bits_per_unit is right?"
>
> I would say it is (at least in conservative way) - anything smaller  
> than
> BITS_PER_UNIT is wrong.  While many architectures mandate greater
> alignment I don't see this being interfaced to middle end and I don't
> think it really matters.

OK. Sounds good.

-eric



More information about the Gcc-patches mailing list