PATCH: calculate CDI_DOMINATORS in tree-ssa-sink

Marcin Dalecki martin@dalecki.de
Thu Jan 4 01:08:00 GMT 2007


Wiadomość napisana w dniu 2007-01-04, o godz01:21, przez Zdenek Dvorak:

> /* Flags for state of loop structure.  */
> enum
> {
>   LOOPS_HAVE_PREHEADERS = 1,
>   LOOPS_HAVE_SIMPLE_LATCHES = 2,
>   LOOPS_HAVE_MARKED_IRREDUCIBLE_REGIONS = 4,
>   LOOPS_HAVE_MARKED_SINGLE_EXITS = 8
> };
>
> (advantage over using #defines being that these constants can be  
> used from debugger).

There are about a hand-full of cases of enum types, where GCC loves
to pass the 0 value instead of a well named enum value during usage.
Some are missing a distinctive value for "I don't care values" and an  
explicite 0.
For example:

enum built_in_function
{
+  BUILT_IN_NONE,
+

would increase type safety a bit.

Mixing VOIDmode with REG_DEP_TRUE is quite common too.
Using plain 0 instead of VOIDmode, 0 instead of STD_C89 as well.
And so on...

Marcin Dalecki




More information about the Gcc-patches mailing list