[rs6000,patch] Fix ppc-specific problem with functions returning logical(8) value

David Edelsohn dje@watson.ibm.com
Mon Feb 12 16:38:00 GMT 2007


	Wouldn't it be cleaner and clearer to write:


  mode = TYPE_MODE (valtype);
  if ((INTEGRAL_TYPE_P (valtype)
       && GET_MODE_BITSIZE (mode) < BITS_PER_WORD)
      || POINTER_TYPE_P (valtype))
    mode = TARGET_32BIT ? SImode : DImode;


In general, the patch is okay on mainline and 4.2.  Please do not include
the patch in 4.1.2.

Thanks, David



More information about the Gcc-patches mailing list