delete unused function longest_path_length

Vladimir N. Makarov vmakarov@redhat.com
Thu Feb 8 15:58:00 GMT 2007


Ian Lance Taylor wrote:

>"Manuel López-Ibáñez" <lopezibanez@gmail.com> writes:
>
>  
>
>>:ADDPATCH middle-end:
>>
>>While fixing PR4076, I found another unused function.
>>
>>Bootstrapped and regression tested with --enable-languages=all on
>>i686-pc-linux-gnu.
>>
>>Goodbye to it?
>>
>>2007-01-31  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
>>
>> * genautomata.c (longest_path_length): Delete unused function.
>>    
>>
>
>I'm in favor of deleting this, but please also delete
>UNDEFINED_LONGEST_PATH_LENGTH and the longest_path_length field of
>struct state.  I'll approve that patch assume it passes bootstrap and
>testing.
>
>Please give Vlad (CC'ed) a day or two to comment, maybe he had
>something in mind for these.
>
>  
>
It was supposed to be used for removing ISSUE_RATE macro.  But the work 
was not finished.  Now the generated value is incorrect when several 
autoamata used (most cases).  So it is ok to delete the function and as 
Ian mentioned the macro UNDEFINED_LONGEST_PATH_LENGTH too.



More information about the Gcc-patches mailing list