[m68k 05/13] improve 64bit shift handling

Roman Zippel zippel@linux-m68k.org
Wed Feb 7 22:08:00 GMT 2007


Hi,

On Tue, 6 Feb 2007, Jeffrey Law wrote:

>   2. You need a function comment before split_di.  Also in
>      split_di s/refuse/refuses/

Hmm, I copied that from i386. :)

>   3. You modified extendsidi2, but it's not mentioned in the
>      ChangeLog.  DId you mean to include it?  (Arguably it
>      could have been in its own patch).

Yes, I'll add it. (It sort of belongs to ashrdi_const32, as generates the 
same code sequence.)

>   4. Do you need a CC_STATUS_INIT in your new *ashrdi3_const1?
>      Similarly for the other shift by one patterns.
> 
>   5. Are the CC status bits correct when we split something
>      like a 32bit shift into moves?

All CC status bits for any shift operation are always cleared by 
notice_update_cc().

bye, Roman



More information about the Gcc-patches mailing list