PR33713: remove -fforce-addr

Hans-Peter Nilsson hans-peter.nilsson@axis.com
Fri Dec 14 12:02:00 GMT 2007


> Date: Fri, 14 Dec 2007 08:25:11 +0100
> From: "Steven Bosscher" <stevenb.gcc@gmail.com>

> On Dec 14, 2007 2:57 AM, Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote:
> > > Date: Tue, 4 Dec 2007 19:13:35 -0400
> > > From: Aldy Hernandez <aldyh@redhat.com>
> >
> > > > Anyway, the point of this communication: was it really a good
> > > > thing to remove all test-cases using -fforce-addr?  Why not just
> > > > remove their -fforce-addr argument?  Can we add them back?
> > >
> > > I don't have a problem with that.  Steven?
> >
> > Any news on this?
> 
> IMHO without -fforce-addr the test cases test nothing that isn't
> already triggered by a gcc build or by another test case.  I see no
> point in keeping aruond test cases that add no test coverage.

You're quick with your dismissals.  When removing -fforce-addr,
code was changed that at least formerly was exercised by the
test-cases.  As a result of that change, the generated code
changed, so without further analysis (as to whether the
execution path now actually is exercised by *these* tests),
keeping the test-cases trivially make sense.  Agree?

brgds, H-P



More information about the Gcc-patches mailing list