[PATCH, ARM] Fix target/30192: wrong sp on exit of floatundidf and floatdidf (hard FPA)

Paul Brook paul@codesourcery.com
Thu Dec 13 01:16:00 GMT 2007


> 2007-11-02  Richard Earnshaw  <rearnsha@arm.com>
>
> 	PR target/30192
> 	* config/arm/ieee754-df.S (floatundidf): Fix for wrong sp value on
> 	exit when using hard FPA.
> 	* config/arm/ieee754-df.S (floatdidf): Likewise.

> +	@ Push pc as well so that RETLDM works correctly.
> +	do_push	{r4, r5, ip, lr, pc}

This is not a valid Thumb-2 instruction. However I doubt anyone actually cares 
about Thumb-2 + FPA - Such hardware doesn't exist, and almost certainly never 
will.  Anyone building Thumb-2 libraries can either use a sane FPU, or figure 
out a better fix.  The assembler generates a hard error in the problematic 
case, so there's no danger of accidental bad code.

Patch applied.

Paul



More information about the Gcc-patches mailing list