[PATCH] Fix PR middle-end/33088

Richard Guenther richard.guenther@gmail.com
Wed Dec 12 23:09:00 GMT 2007


On Dec 12, 2007 11:39 PM, Eric Botcazou <ebotcazou@libertysurf.fr> wrote:
> > I think the idea and implementation are sound.  But, did you verify
> > that the places
> > we set DECL_GIMPLE_REG_P in the gimplifier are properly guarded with the
> > changed predicate?  That is, shouldn't the occurances of
> >
> >       if ((TREE_CODE (TREE_TYPE (parm)) == COMPLEX_TYPE
> >
> >            || TREE_CODE (TREE_TYPE (parm)) == VECTOR_TYPE)
> >
> > ...
> >         DECL_GIMPLE_REG_P (parm) = 1;
> >
> > changed to use the is_gimple_reg_type predicate?  (at least in the
> > gimplifier)
>
> It seems to me that I already answered to this question in the message. :-)
>
> The rationale is that the flag is only really read through is_gimple_reg.

Doh, right.  Sorry ;)

I think the patch is ok.

Thanks,
Richard.



More information about the Gcc-patches mailing list