Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c

Joseph S. Myers joseph@codesourcery.com
Wed Dec 5 22:53:00 GMT 2007


On Wed, 5 Dec 2007, NightStrike wrote:

> On 12/4/07, Joseph S. Myers <joseph@codesourcery.com> wrote:
> > On Tue, 4 Dec 2007, NightStrike wrote:
> >
> > > http://gcc.gnu.org/ml/gcc-patches/2007-04/msg00767.html
> > >
> > > This old thread is in need of review to help the x86_64-pc-mingw32
> > > port of gcc.  It's been about 8 months so far.  Any takers to review
> > > the patch?
> >
> > If there is a patch with full testcases, please point to it - that patch
> > appears to be one without testcases, and so not ready for review.
> 
> I think Kai was waiting until your review before making the testcases.
>  Can you at least evaluate what's there already?

No, in the original discussions leading to that patch we already discussed 
the general nature of what the feature should look like at the language 
level, and assessing whether the patch meets that requires testcases (and 
changes to existing testcases) that provide proper coverage of the new and 
existing features and leave all the format checking tests passing on both 
MinGW and non-MinGW targets.

If after reviewing testcases and code I suspect problems in areas not 
covered by the tests I build the compiler with a patch when reviewing it 
and try my own tests, but the basic tests to provide thorough coverage of 
the patch are the responsibility of the patch submitter.  This (and 
diagnostic-related patches in general) is the sort of patch I review 
primarily by examining the testcases to see if I agree with the 
diagnostics asserted to be present or absent and that the testcases appear 
to cover the feature as described, and only secondarily if the testcases 
appear correct and adequate by examining the implementation.

I made clear on 25 April 
<http://gcc.gnu.org/ml/gcc-patches/2007-04/msg01734.html> that I was 
awaiting testsuite changes.  I do not think there is any open question 
regarding the principle of the feature (where partial patches might be of 
value in assessing how worthwhile a feature is bearing in mind the cost of 
the implementation); what needs review is the quality of an 
implementation, and that needs a complete patch submission.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list