[PATCH] Fix includes of sparseset.*

Peter Bergner bergner@vnet.ibm.com
Tue Dec 4 15:01:00 GMT 2007

On Sat, 2007-12-01 at 13:41 +0100, Bernhard Fischer wrote:
> On Wed, Nov 28, 2007 at 10:44:12AM -0700, Tom Tromey wrote:
> >>>>>> "Bernhard" == Bernhard Fischer <rep.dot.nop@gmail.com> writes:
> >
> >Bernhard> 	* sparseset.h: Include config.h before system.h
> >Bernhard> 	* sparseset.c: Remove inclusion of libiberty.h
> >
> >I think it is a bit odd to include config.h from a header.
> >
> >Instead, I think as a rule every .c file should include config.h as
> >the first header.
> Updated patch attached. Bootstrapped and regtested on i386-linux-gnu
> without any new regression. Ok for trunk?

This bootstrapped for me on powerpc64-linux with no errors.  I ran the
testsuite, but I don't have baseline results to compare with it at the
moment.  I'm not sure I can approve this even though I wrote the files,
but it looks good to me.


More information about the Gcc-patches mailing list