[PATCH] Fix includes of sparseset.*

Bernhard Fischer rep.dot.nop@gmail.com
Sat Dec 1 12:42:00 GMT 2007


On Wed, Nov 28, 2007 at 10:44:12AM -0700, Tom Tromey wrote:
>>>>>> "Bernhard" == Bernhard Fischer <rep.dot.nop@gmail.com> writes:
>
>Bernhard> 	* sparseset.h: Include config.h before system.h
>Bernhard> 	* sparseset.c: Remove inclusion of libiberty.h
>
>I think it is a bit odd to include config.h from a header.
>
>Instead, I think as a rule every .c file should include config.h as
>the first header.

Updated patch attached. Bootstrapped and regtested on i386-linux-gnu
without any new regression. Ok for trunk?

gcc/ChangeLog:
2007-11-27  Bernhard Fischer  <>

        * sparseset.c: Include config.h and system.h before sparseset.h.
        * sparseset.h: Remove inclusion of system.h.


thanks,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcc-4.3-fix-sparseset-includes.01.diff
Type: text/x-diff
Size: 1327 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071201/2f5cb689/attachment.bin>


More information about the Gcc-patches mailing list