[PATCH INSTALLED]: const typedefs part 19/N

[Daniel Berlin]

On 8/27/07, Daniel Berlin <dberlin@dberlin.org> wrote:
> On 8/26/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> > This patch constifies cfg_hooks and debug_hooks, plus a bunch of of other
> > random predicates.
> >
> > Bootstrapped on sparc-sun-solaris2.10, no regressions.  I also ran my
> > cross-compile farm to check platforms with other debug-types activating
> > different debugging code in the various *out.c files.  I didn't see any
> > relevant warnings from building cc1 to those targets.
> >
> > Installed on mainline.
> >
> >                 --Kaveh
> >
> const_last_stmt vs last_stmt?
>
> Please, no.
>
> That crosses the line for me from "i don't care if you want to
> constify a bunch of things" to "stop making the code look horrible".
> Really, all something like that will do is confuse people.
...
> I kindly ask you to revert your change to make const_last_stmt and
> last_stmt (and others new functions that are prefix'd with const_)
>

(to clarify, this also includes bsi_ vs cbsi_*).