[patch] m68k: Use ASSEMBLER_DIALECT

Bernardo Innocenti bernie@codewiz.org
Mon Aug 27 04:41:00 GMT 2007


On 08/26/2007 03:59 PM, Kazu Hirata wrote:

> I assigned option 0 to the Motorola syntax because the motorola syntax
> adds characters to the MIT syntax.  This way, we can say
> 
>   j{b}eq
> 
> rather than more cumbersome
> 
>   j{|b}eq

I think it's a worthwhile simplification, even though it has
a small impact on performance and code size.


> I didn't go as far as replacing "%." with "{.}".  We can do that
> another time if people agree that it's a good idea.  Personally, I
> would like to have only one way, namely "{|}", to handle dialects, but
> "{.}" is longer than "%.".

Even better, I'd like to see the m68k backend switch to
a higher level description for outputing asm instructions rather
than cumbersome strings full of escapes and formatting codes.

IIRC, the avr backend was using a very clean solution.  With proper
inlining, performance shouldn't even be an issue.

Another random idea: maybe we could genericize the avr idea
so it could be used in all backends.  The actual wrappers could
even be generated out of the bfd machine descriotions.


> Tested on m68k-elf.  OK to apply?

Although I can't approve patches, I ack this one.

-- 
   // Bernardo Innocenti
 \X/  http://www.codewiz.org/



More information about the Gcc-patches mailing list