[PATCH][RFC] Introduce type safety and debuggability into tree.h
Mark Mitchell
mark@codesourcery.com
Thu Aug 9 22:39:00 GMT 2007
Simon Baldwin wrote:
> This patch replaces some of the function-like macros in gcc/tree.h with
> static inlined function equivalents.
I like this idea.
Just to double-check performance: you've compared performance of a
bootstrapped --disable-checking compiler with this change, right? What
about size of the compiler?
I do have one request about this patch: make it easier for yourself by
not changing the case of the macros. That will avoid the mass changes
through all the other files, and will make life a lot easier for people
who backport or merge patches often. (Yes, that's self-interested, but
I don't think it's just CodeSourcery that does that.) Sure, the coding
standards may say that ALL_CAPS is for macros, but I just don't see the
value in this kind of mass change.
This isn't an approval, because I want you to confirm the performance
questions above, and because I want to give other people a chance to
object. But, I will approve this strategy assuming that others don't
complain.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
More information about the Gcc-patches
mailing list