[PATCH] Wrong line number for the closing brace of template functions
Dave Korn
dave.korn@artimi.com
Mon Aug 6 18:47:00 GMT 2007
On 06 August 2007 19:11, Mark Mitchell wrote:
> However, this comment:
>
> + /* Make sure the current input_location
> + is set correctly to the end of the function
> + - this makes finish_function to set
> + function_end_locus of this specialization correctly. */
>
> could be written better as:
>
> /* Set the current input_location to the end of the function so
> that finish_function knows where we are. */
>
> The "makes x to set y" construct is not grammatical.
FYI, anyone whose first language isn't English:
The very similar construction "causes x to set y" is grammatical, and although "makes" and "causes" mean the same in this context, only "causes" may be used in that construct. "makes x set y" would also be grammatical. (I don't know why "causes" requires an infinitive (actually, probably a gerund) and "makes" requires a finite verb phrase, but there you go).
cheers,
DaveK
--
Can't think of a witty .sigline today....
More information about the Gcc-patches
mailing list