[PING][PATCH/RFT] Fix PR middle-end/PR28690, modify swap_commutative_operands_p

[H. J. Lu]

On Thu, Apr 26, 2007 at 02:01:20PM -0500, Peter Bergner wrote:
> Hi,
> 
> Ian has approved the following patch:
> 
>     http://gcc.gnu.org/ml/gcc-patches/2007-04/msg01111.html
> 
> assuming there are no performance regressions.  I'd like to
> ask that some people to test the patch to make sure it does
> not produce any performance regressions on their favorite
> architectures.  We have run this on POWER5 and POWER6 as
> well as x86.  However, we haven't had much experience running
> SPEC on x86, so I'd feel better if someone could corroborate
> our numbers.

I tried your patch on gcc 4.3 revision 123850. But eon in SPEC
CPU 2K failed on Linux/ia32 at -O2. I have

252.eon=default=default=default:
CXXPORTABILITY = -DHAS_ERRLIST
srcalt=fmax_errno

and got

  Running 252.eon ref base o2 default
*** Miscompare of pixels_out.kajiya, see
/export/spec/src/2000/spec/benchspec/CINT2000/252.eon/run/00000002/pixels_out.kajiya.mis
Invalid run; unable to continue.  If you wish to ignore errors please
use '-I' or ignore_errors

There is no problem with gcc 4.3 revision 123850 without your patch.
Does gcc 4.3 revision 123850 plus your patch work with SPEC CPU 2K
on Linux/ia32? What is your config on eon?


H.J.