[PATCH]: Fix PR rtl-optimization/29841: cfgbuild.c: control_flow_insn_p () .

Eric Botcazou ebotcazou@libertysurf.fr
Tue Apr 17 07:51:00 GMT 2007


> The patch forces any insn that has a barrier after it be
> control_flow_insn_p thus making it impossible for barrier to appear
> inside basic block.  An example of such insn is
> (insn (trap_if (const_int 1))) on i586-pc-linux-gnu.

This sounds like a kludge to me, and the comment in the patch has nothing to 
do with the problem AFAICS.  I think that we should always be able to tell 
whether an insn is control_flow_insn_p by looking at its pattern only (modulo 
the presence of EH stuff).

-- 
Eric Botcazou



More information about the Gcc-patches mailing list