[PATCH]: Fix PR rtl-optimization/29841: cfgbuild.c: control_flow_insn_p () .

Jan Hubicka jh@suse.cz
Mon Apr 16 16:31:00 GMT 2007


> Maxim Kuvyrkov wrote:
> >Hi,
> >
> >This patch was proposed by Jan Hubicka but wasn't committed because of 
> >some unknown reason.  I bootstrapped/regtested it on x86-64 and took the 
> >liberty of submitting it here.
> >
> >The patch forces any insn that has a barrier after it be 
> >control_flow_insn_p thus making it impossible for barrier to appear 
> >inside basic block.  An example of such insn is
> >(insn (trap_if (const_int 1))) on i586-pc-linux-gnu.
> >
> >Jan, can you please check in the patch?
> 
> And here comes the patch.
> 
> 
> Thanks,
> 
> Maxim

> 2007-01-15  Maxim Kuvyrkov  <mkuvyrkov@ispras.ru>
> 
> 	PR rtl-optimization/29841
> 	* cfgbuild.c (control_flow_insn_p): Force insn that have a barrier
> 	after it be control_flow_insn_p.
> 	* cfgrtl.c (rtl_verify_flow_insn_1): Strengthen check.

This patch definitly looks OK to me (there is no reason to allow
something like barrier within basic block). I however can't approve
patches to this area.  

Honza



More information about the Gcc-patches mailing list