avoid C++ keywords in gensupport.c

Gabriel Dos Reis gdr@cs.tamu.edu
Thu Apr 12 15:59:00 GMT 2007


 Thomas Neumann <tneumann@users.sourceforge.net> writes:

| Hi,
| 
| the attached patch avoids the C++ keyword "new" in gensupport.c and adds
| a required cast (i.e. recommended in C, required in C++). Please apply
| it if you find it useful.

Hi Thomas,

  Thanks for following up.  

  I believe we need a copyright assignment from you -- individual patch
looks trivial but they accumulate.  Furthermore, it would be better if
you had a write-after-approval account.  Since I have an interest in
this work, I may sponsor your account; however, we need a copyright
assignment from you.

[...]

| +      new_name = (char*) xmalloc (strlen (last_real_name) + 10);

This should be:

    new_name = XNEWVEC(char, strlen (last_real_name) + 10);

Similar remarks for other xmalloc.  Please, see whether they are
vector allocation of just single object allocation and use the
appropriate form.  Thanks!


-- Gaby



More information about the Gcc-patches mailing list