[1/4] [patch, middle-end] Make mpz_set/get_double_int functions non-static.

Daniel Berlin dberlin@dberlin.org
Mon Apr 9 21:11:00 GMT 2007


On 4/8/07, Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz> wrote:
> Hello,
>
> > The attached patch (same as before, except with these changes) has been
> > tested with "make check-gcc" on i686-pc-linux-gnu; it seems to work fine
> > except for a bunch of unrelated staticp failures.  Ok?
>
> I am sorry I come up with the issues one by one; since I do not have
> rights to approve this patch, I did not study it in detail before:
>
> > +  if (!TREE_CODE (type) == POINTER_TYPE
>
> TREE_CODE (type) != POINTER_TYPE
>
> > +      && TYPE_MIN_VALUE (type)
> > +      && TREE_CODE (TYPE_MIN_VALUE (type)) == INTEGER_CST)
> > +    mpz_set_double_int (min, tree_to_double_int (TYPE_MIN_VALUE (type)),
> > +                     TYPE_UNSIGNED (type));
>
> > +  if (!TREE_CODE (type) == POINTER_TYPE
>
> TREE_CODE (type) != POINTER_TYPE

Or !POINTER_TYPE_P (type)

Remember that POINTER_TYPE is not the only pointer type :(

>
> > +      && TYPE_MAX_VALUE (type)
> > +      && TREE_CODE (TYPE_MAX_VALUE (type)) == INTEGER_CST)
> > +    mpz_set_double_int (max, tree_to_double_int (TYPE_MAX_VALUE (type)),
> > +                     TYPE_UNSIGNED (type));
>
> Zdenek
>



More information about the Gcc-patches mailing list