PATCH: Enable __declspec(align(N)) for x86

Richard Guenther richard.guenther@gmail.com
Tue Apr 3 16:32:00 GMT 2007


On 4/3/07, H. J. Lu <hjl@lucon.org> wrote:
> On Mon, Apr 02, 2007 at 03:41:29PM -0700, H. J. Lu wrote:
> > On Mon, Apr 02, 2007 at 03:35:01PM -0700, Mike Stump wrote:
> > > On Apr 2, 2007, at 3:18 PM, H. J. Lu wrote:
> > > >-    builtin_define ("__declspec(x)=__attribute__((x))");
> > > >+    {
> > > >+      builtin_define ("align(x)=aligned((x))");
> > >
> > > On second thought...  I don't want this, too dangerous..  better to
> > > have align accepted in an attribute.
> >
>
> We can't include "c-common.h" in config/i386/i386.c since not
> all frontends are linked with c-common.o.  This patch adds
> TARGET_ALIGN_DECL_ATTRIBUTES so that we can add align(N) to
> c-common.o.

I'd say we should rather accept it always.  A target speciality for this
just asks for typos to become portability problems.

Richard.



More information about the Gcc-patches mailing list