[lto] PATCH: map/unmap LTO sections, + bug fixes

Mark Mitchell mark@codesourcery.com
Wed Sep 20 21:33:00 GMT 2006


Richard Sandiford wrote:

>> I think you have a memory leak here: "name" will be allocated with 
>> malloc, but you never free it.  I think you should call free before 
>> returning, independent of the value returned by lto_elf_find_section_data.
> 
> FWIW, another option would be to use ACONCAT.

Good idea, thanks!  (Sandra, I don't think there's any compelling reason 
to change this, thought it would be a minor optimization, but I'm going 
to try to file that away in my brain for next time...)

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713



More information about the Gcc-patches mailing list