[PATCH] PR6321
Mark Mitchell
mark@codesourcery.com
Mon Oct 30 23:08:00 GMT 2006
Dirk Mueller wrote:
> 2006-10-30 Dirk Mueller <dmueller@suse.de>
>
> PR c++/6321
> * c-decl (start_function): Move code for main decl warning ..
> * c-common.c (check_main_arguments): .. here.
> * c-common.h (check_main_arguments): Declare.
>
> * decl.c(grokfndecl): Use check_main_arguments.
This is OK, thanks.
(Pedantically, I think "check_main_parameter_types" would be better;
generally "arguments" are the things you pass to a function, while
"parameters" are the things that get replaced by the arguments when you
run the function. But, GCC doesn't adhere to this convention in many
other places, and I don't want to make you tweak your patch any more.
So, you can decide whether to do that or not, as you please.)
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
More information about the Gcc-patches
mailing list