[PATCH] Fix PR29512, O(c^N) complexity algorithm in the i386 backend

[Richard Guenther]

On Fri, 20 Oct 2006, Jan Hubicka wrote:

> > But the BINFO walking is redundant
> > completely anyway, as we are only interested in seeing all structure
> > data members which are also available by walking the TYPE_FIELDs like
> > the rest of the middle-end does.
> 
> This is very important, so I would feel safer if some C++ person can
> confirm this. The patch is potentially ABI breaking...
> > 
> > Ok for mainline?  (note this doesn't seem to be a regression other than
> > a regression from i686 to x86_64)
> > 
> > Thanks,
> > Richard.
> > 
> > :ADDPATCH i386:
> > 
> > 2006-10-20  Richard Guenther  <rguenther@suse.de>
> > 
> > 	PR target/29512
> > 	* config/i386/i386.c (classify_argument): Remove redundant
> > 	walking of the BINFOs.
> > 	(contains_128bit_aligned_vector_p): Likewise.
> 
> Given that the patch passed testing on various C++ codebases and rest of
> backend really seem to assume that TYPE_FIELDs contain everything what
> is linked by BINFOs, the patch is OK.
> 
> I've added some info to the PR audit trail how we got to this situation.

I have applied the patch to the mainline (4.3) for now.

Richard.

--
Richard Guenther <rguenther@suse.de>
Novell / SUSE Labs