more pthread fixincludes patch
Uros Bizjak
ubizjak@gmail.com
Tue Oct 3 05:14:00 GMT 2006
On 10/2/06, Bruce Korb <bruce.korb@gmail.com> wrote:
> One small complaint and one nitpick, the fix looks fine
> whether you address them or not:
>
> 1. To me, it is clearer - easier to understand - if sed commands
> are separated into separate "sed" assignments. I understand
> that the "\n" character makes for two commands, it is just
> easier (for me) to understand with additional separation.
The rationale for this approach was, that we actually do almost the
same substitution in two places. I was under impression that using one
sed command perhaps instructs sed to optimize some of its work. I'll
change this to preferred style.
> 2. Likely not worth the bother now, but for future reference:
>
> test_text = <<- _EOText_
> #define PTHREAD_MUTEX_INITIALIZER \
> { { 0, } }
> #ifdef __USE_GNU
> # if __WORDSIZE == 64
> [[ ... ]]
> _EOText_;
>
> makes for more readable text, too.
Thanks for the suggestion, I'll also change this.
Uros.
More information about the Gcc-patches
mailing list