[C/C++ PATCH] Reorganize c-common.c's convert_and_check (take 2)

Joseph S. Myers joseph@codesourcery.com
Mon Nov 27 12:43:00 GMT 2006


On Sat, 25 Nov 2006, Manuel Lopez-Ibanez wrote:

> 2006-11-25  Roger Sayle  <roger@eyesopen.com>
>                    Manuel Lopez-Ibanez <manu@gcc.gnu.com>
                                                      ^^^^ .org

>      * c-common.c (constant_fits_type_p): Delete.
>      (unsigned_conversion_warning): Delete.
>      (conversion_warning): Integrate Wconversion warning from
>      unsigned_conversion_warning().
>      (convert_and_check): Integrate Woverflow warning from
>      unsigned_conversion_warning().  Reorganize and simplify to avoid
>      dependence upon the middle-end setting TREE_OVERFLOW on integral
>      conversions, by using int_fits_type() directly.

The function is called int_fits_type_p not int_fits_type.

Do not write foo() to refer to a function, see the GNU Coding Standards:

   Please do not write `()' after a function name just to indicate it is
   a function. foo () is not a function, it is a function call with no
   arguments.

This is OK (with those ChangeLog changes) subject to it having passed the 
"no changes in the C/C++ diagnostics issued anywhere in the testsuite" 
test described in Roger's original message.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list