[PATCH] Small cleanups to cse.c

Steven Bosscher stevenb.gcc@gmail.com
Sat Nov 25 16:35:00 GMT 2006


On 11/25/06, Eric Botcazou <ebotcazou@libertysurf.fr> wrote:
> > @@ -3715,9 +3710,11 @@ record_jump_equiv (rtx insn, int taken)
> >    int reversed_nonequality = 0;
> >    enum rtx_code code;
> >
> > +#ifdef ENABLE_CHECKING
> >    /* Ensure this is the right kind of insn.  */
> > -  if (! any_condjump_p (insn))
> > -    return;
> > +  gcc_assert (any_condjump_p (insn));
> > +#endif
>
> gcc_assert is generally not guarded like that.  Could you add a small comment?

Actually, that looks like a mistake.  I should have typed

  if (!any_condjump_p (insn))
    gcc_unreachable ();

there, without the ENABLE_CHECKING.  I'll fix that.  Thanks for catching this.

Gr.
Steven



More information about the Gcc-patches mailing list