[Fortran,patch] Add IMPORT support (PR27546)

Brooks Moses brooks.moses@codesourcery.com
Wed Nov 15 06:02:00 GMT 2006


Steve Kargl wrote:
> On Wed, Nov 08, 2006 at 10:59:44AM +0100, Tobias Burnus wrote:
> +	case MATCH_YES:
> +          if (gfc_find_symbol (name, gfc_current_ns->parent, 1, &sym))
> +            {
> +               gfc_error ("Type name '%s' at %C is ambiguous", name);
> +               return MATCH_ERROR;
> +            }
> +          if (sym == NULL)
> +            {
> +              gfc_error("Can not IMPORT '%s' from host scoping unit "
> +                        "at %C - does not exist.", name);
> 
> Missing space.

Also, the error message should not end with a period, according to the 
GNU standards (and common practice in the rest of gfortran; we have 
about six exceptions to the rule, and I'm currently regtesting a patch 
to fix them too).

(I think that should be "Cannot", as one word rather than two, as well.)

> +            {
> +              gfc_warning("'%s' is already IMPORTed from host scoping unit "
> +                        "at %C.", name);
> 
> Ditto.

And same here with the period, as well.

- Brooks



More information about the Gcc-patches mailing list