[RFT/RFA] bashjar patch

Paolo Bonzini paolo.bonzini@lu.unisi.ch
Tue May 23 09:27:00 GMT 2006


>> +if test "$ZIP" = no; then
>> +  if test "$JAR" = no; then
>> +    AC_MSG_ERROR([cannot find neither zip nor jar, cannot continue])
>> +  fi
>> +else
>> +  # InfoZIP available, use the 'guaranteed' Bourne-shell JAR to build libjava
>> +  JAR=`pwd`/scripts/jar
>>  fi
> 
> I think this is backwards.  You are always using the shell jar when zip is
> available, even if a jar program was found.

I know, it's there to avoid possible incompatibilities/bugs in the found 
JAR program.  Also, the shell JAR might even be faster than Sun's JAR 
because zlib is faster than the 100% Pure Java ;-) java.util.zip package.

Paolo



More information about the Gcc-patches mailing list