Patch ping

Uttam Pawar uttamp@us.ibm.com
Mon Mar 13 19:23:00 GMT 2006


Roger,

Thanks for reviewing the patches and for your feedback.

> The bt-load.c fix is OK, to close PR rtl-optimiztion/25739.
> I think the other changes are suitably obvious enough, even if
> not part of the middle-end, that I can approve them.  Remember
> to commit the version with the "if" checks before the calls to
> free, and mention the above PR number in the ChangeLog entry.

Here is a complete patch again. This has been regtest on powerpc64-linux
with no new regressions.
If it looks ok, could you commit it please, as I do not have commit
access.

Thanks,

Uttam

2006-03-13  Uttam Pawar  <uttamp@us.ibm.com>

        * gensupport.c (identify_predicable_attribute): Free
        p_false pointer.
        * gcov.c (create_file_names): Free name pointer.

        PR rtl-optimization/25739
        * bt-load.c (augment_live_range): Free tos pointer.

Index: gcc/gensupport.c
===================================================================
*** gcc/gensupport.c    (revision 111144)
--- gcc/gensupport.c    (working copy)
*************** identify_predicable_attribute (void)
*** 464,469 ****
--- 464,471 ----
        message_with_line (elem->lineno,
                         "attribute `predicable' is not a boolean");
        errors = 1;
+       if (p_false)
+         free (p_false);
        return;
      }
    p_true[-1] = '\0';
*************** identify_predicable_attribute (void)
*** 481,492 ****
--- 483,498 ----
        message_with_line (elem->lineno,
                         "attribute `predicable' cannot be const");
        errors = 1;
+       if (p_false)
+         free (p_false);
        return;

      default:
        message_with_line (elem->lineno,
                         "attribute `predicable' must have a constant default");
        errors = 1;
+       if (p_false)
+         free (p_false);
        return;
      }

*************** identify_predicable_attribute (void)
*** 501,506 ****
--- 507,515 ----
                         value);
        errors = 1;
      }
+
+   if (p_false)
+     free (p_false);
  }

  /* Return the number of alternatives in constraint S.  */
Index: gcc/gcov.c
===================================================================
*** gcc/gcov.c  (revision 111144)
--- gcc/gcov.c  (working copy)
*************** create_file_names (const char *file_name
*** 658,663 ****
--- 658,664 ----
    strcpy (da_file_name, name);
    strcpy (da_file_name + length, GCOV_DATA_SUFFIX);

+   free (name);
    return;
  }

Index: gcc/bt-load.c
===================================================================
*** gcc/bt-load.c       (revision 111144)
--- gcc/bt-load.c       (working copy)
*************** augment_live_range (bitmap live_range, H
*** 911,916 ****
--- 911,917 ----
        {
          if (full_range)
            IOR_HARD_REG_SET (*btrs_live_in_range, btrs_live[new_bb->index]);
+         free (tos);
          return;
        }
        *tos++ = new_bb;




More information about the Gcc-patches mailing list