Patch queue and reviewing (Was Re: Generator programs can only be built with optimization enabled?)

Richard Guenther richard.guenther@gmail.com
Wed Jun 14 15:08:00 GMT 2006


On 6/14/06, Diego Novillo <dnovillo@redhat.com> wrote:
> Daniel Berlin wrote on 06/13/06 23:24:
>
> > Does anyone believe this would help make sure patches stop dropping
> > through the cracks?
> >
> Not really.  Technical solutions to social problems rarely work.  Patch
> review is mostly a social problem.  I am frequently part of the problem,
> unfortunately.  Mostly this is a time constraint problem, there are only
> so many hours in a working day.
>
> I don't really have a good idea on how to address the core problem,
> other than to encourage adding more maintainers.  A couple of Summits
> ago I think we discussed the idea of having secondary maintainers: folks
> who may not feel fully confident about an area, but may want to chime in
> with an initial review which the primary maintainer could then use to
> help with the final review.
>
> That doesn't mean that the patch queue is a bad idea.  On the contrary,
> but if a patch is destined to fall through the cracks, no amount of
> technical infrastructure will prevent it from doing so.

Some time ago I invented the obvious-because-nobody-cares rule under which
you can apply a patch as obvious if nobody objected after two weeks.

At least this is a workaround for the social problem (and creates another).

;)  Richard.



More information about the Gcc-patches mailing list