[PATCH] Detect obsolete glibcs or kernel headers in libgomp configury (PR libgomp/26175, libgomp/26477)

[Mark Mitchell]

Jakub Jelinek wrote:

> So, what about:
> 1) if SYS_gettid/SYS_futex is not in headers, --disable-linux-futex
>    (by default) or error at configure time (if user tried
>    --enable-linux-futex) - in this case libgomp wouldn't compile otherwise,
>    so it is better to compile somehow

Yes.

> 2) if it is there, do the compile time check and if building against NPTL,
>    default to --enable-linux-futex

Yes.

> 3) optionally for native, check for getconf -> LinuxThreads and
>    --disable-linux-futex in that case, or e.g. just print a warning
>    that it might not work and that the user should consider
>    --disable-linux-futex

I'm happy with the warning option.  I'm unhappy with auto-disabling
because that is again different for cross vs. native.

> 4) default to --enable-linux-futex

Yes.

I think that scenario is fine.  Like you, I'm not worried about people
with new headers with old kernels; that's dangerous in lots of ways.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713