[patch] improve handling of ms_struct

Eric Christopher echristo@apple.com
Sun Jun 4 19:55:00 GMT 2006


On Jun 3, 2006, at 10:08 AM, Roger Sayle wrote:

>
> Hi Eric,
>
> Re: http://gcc.gnu.org/ml/gcc-patches/2006-04/msg01064.html
> Re: http://gcc.gnu.org/ml/gcc-patches/2006-05/msg01214.html
> Re: http://gcc.gnu.org/ml/gcc-patches/2006-05/msg01282.html


> This is OK for mainline.  For those not following the thread, this is
> effectively a bug-fix for Microsoft-compatible structure layout and
> is therefore suitable for stage3.  We should be on the look out for
> problems from the cygwin and mingw folks, who might inadvertantly be
> relying on GCC's current non-MS structure layout behaviour.
>

Thanks. And yes, I'll pay attention to bug reports from anyone about  
this.

> p.s. when you updated and reposted your patch on the 24th, you should
> probably have updated the ChangeLog entries from "2006-05-19" to
> "2006-05-24" to avoid any ambiguity when pinging/approving, and to
> enable the correct post to be identified on gcc-patches if the posts
> become unthreaded (as in this case).  This was likely just an  
> oversight
> this time, but to confirm it's the revised patch that I've approved:
> http://gcc.gnu.org/ml/gcc-patches/2006-05/msg01282.html
>

It was. Thanks.

> Thanks (and to Joseph for reviewing the documentation changes),
> Sorry this has taken so long to get into the tree.

No worries at all. It's a pain of a patch to review. :)

-eric



More information about the Gcc-patches mailing list