[JAVA] /bin/sh portability issues in scripts/jar.in
Paolo Bonzini
paolo.bonzini@lu.unisi.ch
Fri Jul 7 07:36:00 GMT 2006
Roger Sayle wrote:
> The following patch is the third in the series to allow use of the
> native /bin/sh on Solaris/x86. These changes allow Paolo Bonzini's
> impressive "jar" script to be used to build libjava on i386-pc-solaris2.10.
>
Thanks.
> The change to the function "copy" replaces the use of the test's "-e"
> operator, which isn't available on solaris, with the more portable "-f".
>
Note that there is another "test -e" a couple of lines below: in fact it
is safe to convert the one you changed to "test -f", but not the other
one. That one would give a wrong error message if changed. But it is
only triggered when there are errors, so we can live with it.
> The second change avoid the "mkdir_p: command not found" error messages.
>
If I get to choose, I'd prefer _mkdir_p.
My 2 cents,
Paolo
More information about the Gcc-patches
mailing list