[Patch, fortran] PR25084, PR20852, PR25085, PR25086 & PR25416 - assumed character length functions

[Paul Thomas]

Tobi,

>
>This is ok, modulo two remarks.  Also, please make sure that the ChangeLog
>lines are not longer than 78 columns (or whatever emacs' fill-paragraph makes
>them), as that way you avoid wrapping in mail and in the editors of people who
>don't use windows wider than 80 columns.
>  
>
OK - is it 78 columns?  I use SciTe and can set the width to whatever I 
want. You've made more than two remarks - which ones shall I take?

>Feel free to add an obsolescence warning, and consider that (part of the)
>patch pre-approved.
>  
>
OK.

> Please add an assert that the callee is indeed an intrinsic. I think the
>
>comment is overly verbose, especially with the assert added, but I'm not
>complaining.
>
>  
>
I tried that - for some reason attr.intrinsic is not set.  I'll work my 
way back to see if I can understand why.  I did not feel that the 
comment was overly verbose - there are too many corners of gfortran that 
are absolutely inexplicable for the lack of comments.  I thought that 
here, where what is being done is not at all evident, a few words would 
not come amiss.  I will take a fresh look at it.

>This type of coding breaks the effort FX put into internationalization.
>  
>
>Please make this
> if (sym->as && sym->as->rank)
>     type = "CHARACTER(*) function '%s' at %L cannot be array-valued";
> else if (sym->attr.pointer)
>     type = "CHARACTER(*) function '%s' at %L cannot be pointer-valued";
>etc.
>
>Or even better:
> if (sym->as && sym->as->rank)
>     gfc_error ("CHARACTER(*) function '%s' at %L cannot be array-valued",
>                sym->name, &sym->declared_at, type);
> if (sym->attr.pointer)
>     gfc_error ("CHARACTER(*) function '%s' at %L cannot be pointer-valued",
>                sym->name, &sym->declared_at, type);
> etc.
>  
>
This is the way that I had it in the first place.  I decided to reduce 
the memory tied up in repeated strings!  Explain to me why this helps 
internationalization, please; I feel an outbreak of ignorance coming on.

My thanks to you for a very rapid review.