[patch] reload1: detail reload failures in dump file

DJ Delorie dj@redhat.com
Fri Jan 20 01:57:00 GMT 2006


> > 	* reload1.c (find_reload_regs): Note the details of reload
> > 	failures in the dump file.
> > 	(spill_failure): Likewise.
> > 
> > Index: gcc/reload1.c
> > ===================================================================
> > *** gcc/reload1.c	(revision 108596)
> > --- gcc/reload1.c	(working copy)
> > *************** find_reload_regs (struct insn_chain *cha
> > *** 1831,1834 ****
> > --- 1831,1836 ----
> >   	if (! find_reg (chain, i))
> >   	  {
> > + 	    if (dump_file)
> > + 	      fprintf(dump_file, "reload failure for reload %d\n", i);
> >   	    spill_failure (chain->insn, rld[r].class);
> >   	    failure = 1;
> 
> Please put a space between the fprintf and the parenthesis.
> 
> More importantly, it seems to me that this should print R, not I.
> Looking at debug_reload_to_stream, reloads seem to be numbered by the
> index in RLD.  In this case the index in RLD is R.
> 
> OK for mainline with those changes if you agree with them.

Oops, forgot this one.  Committed with your suggested changes.



More information about the Gcc-patches mailing list