[PATCH][stage2 project] Sub-Target specific math routines library
Paolo Bonzini
paolo.bonzini@lu.unisi.ch
Thu Jan 19 16:09:00 GMT 2006
>>The patch almost satisfies me (see below), but you'd need a build
>>machinery maintainer approval for the configury bits.
I cannot approve it, but I will comment on a few bits that can be improved.
>>| + # Set the default so we build libgcc-math for ix86 and x86_64
>>| + case "${target}" in
>>| + i?86-*)
>>| + libgccmdefault=yes ;;
>>| + x86_64-*)
>>| + libgccmdefault=yes ;;
>>| + *)
>>| + libgccmdefault=no ;;
>>
>>s/libgccmdefault/libgcc_mathdefault/?
>
> Ok.
Since you are at it, libgcc_mathdefault. Or you could sink it into the
AC_ARG_ENABLE macro, and set enable_libgcc_math directly.
>>| + esac
>>| + AC_ARG_ENABLE(libgcc-math,
>>| + [ --enable-libgcc-math Builds libgcc-math directory],
>>| + ENABLE_LIBGCCM=$enableval,
>>| + ENABLE_LIBGCCM=$libgccmdefault)
>>
>>s/LIBGCCM/LIBGCC_MATH/?
>
> Ok. (They are just local shell temps, but for consistency I'll change
> them)
No need. Just do
AC_ARG_ENABLE(libgcc-math,
[ --enable-libgcc-math Builds libgcc-math directory],,
enable_libgcc_math=$libgcc_math_default)
... because configure already copies the argument from $enableval into
$enable_libgcc_math. In fact AC_ARG_ENABLE is mostly useful to set a
default and to provide a help string.
Paolo
More information about the Gcc-patches
mailing list