[patch] testcase for exception table labels

Eric Christopher echristo@apple.com
Thu Jan 19 01:26:00 GMT 2006


On Jan 18, 2006, at 4:59 PM, Mike Stump wrote:

> On Jan 18, 2006, at 10:41 AM, Dale Johannesen wrote:
>> On Jan 18, 2006, at 12:35 AM, Mike Stump wrote:
>>>> 2006-01-17  Eric Christopher  <echristo@apple.com>
>>>>
>>>>     * g++.dg/eh/table.cpp: New test.
>>>
>>> No, please use .C to be consistent with the rest of the testsuite.
>>
>> There should be some with .cpp extension, otherwise we won't be  
>> testing that it works.   Consistency in a testsuite is not a  
>> virtue; the idea should be to test as many things as possible.
>
> Maybe you're not aware of:
>
> 	set tests [lsort [find $srcdir/$subdir *.C]]
>
> in dg.exp.
>
> A testcase that tests differently named source code is fine, but it  
> isn't this testcase, and it isn't run by dg.exp.

Interestingly, btw, it appears that RUNTESTFLAGS="dg.exp=table.cpp"  
did test it. :)

At any rate, checked in the testcase with the other extension.

-eric



More information about the Gcc-patches mailing list