[gfortran, PR 18540] A few statement label cleanups

Tobias.Schlueter@Physik.Uni-Muenchen.DE Tobias.Schlueter@Physik.Uni-Muenchen.DE
Wed Jan 18 20:46:00 GMT 2006


Quoting Steve Kargl <sgk@troutmask.apl.washington.edu>:
> > Built and tested on i686-linux previously, new testcase attached.  Ok?
> >
>
> Tobi, I've read the patch and believe that it is correct.
> I particularly like the clean up of the unused 'cnt' variable
> that I added in a few places.   Although I can't test the
> patch at the moment, I think it should be committed to trunk.
> In a week or so, the patch can be committed to 4.1.

Thanks.  I had accidentally sent a preliminary version of the patch in which I
had omitted the initialization of 'cnt' to zero in gfc_math_small_literal_int.
I'll consider readding the initialization obvious, and check this in as
attached.   ChangeLog as before with 'Only set cnt if non-NULL.' removed. 
Actually, I find the necessity for this a bit awkward, as we use the cnt
parameter to distinguish between a number of error messages in the case where
the matching fails, but this is a cleanup for another patch.

- Tobi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: partial.diff
Type: application/octet-stream
Size: 9629 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20060118/dc4a73ea/attachment.obj>


More information about the Gcc-patches mailing list