-mtune=generic for i386 backend

Jan Hubicka hubicka@ucw.cz
Wed Jan 18 08:09:00 GMT 2006


> On Wed, Jan 18, 2006 at 12:25:07AM +0100, Jan Hubicka wrote:
> > + #define TARGET_CPU_DEFAULT_generic 17
> >   
> >   #define TARGET_CPU_DEFAULT_NAMES {"i386", "i486", "pentium", "pentium-mmx",\
> >   				  "pentiumpro", "pentium2", "pentium3", \
> >   				  "pentium4", "k6", "k6-2", "k6-3",\
> >   				  "athlon", "athlon-4", "k8", \
> > ! 				  "pentium-m", "prescott", "nocona", "generic"}
> ...
> >     PROCESSOR_NOCONA,
> > +   PROCESSOR_GENERIC32,
> > +   PROCESSOR_GENERIC64,
> 
> These aren't being kept in sync.  IIRC that's badness.  Of course,

Yep, it is unfortunate disprepancy in between user visible names and
internal names (user sees single "generic", while internally those are
two CPUs).  I don't see this easilly avoidable and those two
enumerations are independent.

Perhaps I can add two "generic" entries in the first to keep numeric
values in sync?

> a better question is why we have multiple enumerations...
> 
> > +   /* All patterns using algined_operand on memory operands ends up
> 
> Typo.
> 
> Otherwise I don't see anything objectionable.  It would be nice
> to paste some of the rationale from your mail into comments at
> appropriate points where generic* settings are set.

This is good idea, I will include it in updated patch.

Honza
> 
> 
> r~



More information about the Gcc-patches mailing list