PATCH: [4.1/4.2 Regression]: Miscompiled FORTRAN program

Denis Nagorny denis_nagorny@linux.intel.com
Thu Feb 16 20:25:00 GMT 2006


Andrew Pinski wrote:

> What about defining the code this way:
> #ifdef AUTO_INC_DEC
> + static int
> + reg_inc_found_and_valid_p (unsigned int regno,
> +                            unsigned int endregno,
> +                            rtx insn)
> + {
> 
> ...
> }
> #else
> 
> #define reg_inc_found_and_valid_p(regno,endregno,insn) 0
> 
> #endif
> 
> So you can remove ugly ATTRIBUTE_UNUSED.
> 
> Thanks,
> Andrew Pinski
> 

Yes. It will be more ellegant and easier for compiler to remove following conditions, but
what about
+ static int reg_inc_found_and_valid_p (unsigned int, unsigned int, rtx);
In this case I must hide this under preprocessor too. I feared to overburden code by preprocessor
expressions.
What is you opinion?

Denis.



More information about the Gcc-patches mailing list